Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Module? #490

Open
csantos1113 opened this issue Oct 23, 2023 · 2 comments · May be fixed by #491
Open

ES Module? #490

csantos1113 opened this issue Oct 23, 2023 · 2 comments · May be fixed by #491

Comments

@csantos1113
Copy link

I see semantic-release ESM was released Jan 6 https://github.com/semantic-release/semantic-release/releases/tag/v20.0.0 and multiple semantic-release plugins were updated to be ESM, including semantic-release/error#249, but not @semantic-release/git, and I couldn't find any issues or PRs related to that.

So I have multiple questions on that regard:

  • Are there plans to update this package to ESM?
  • How is this plugin not breaking?

Thank you
@csantos1113 csantos1113 linked a pull request Oct 23, 2023 that will close this issue
Open
@travi
Copy link
Member

travi commented Nov 1, 2023

as mentioned in our thread about the initial esm conversion, we are looking for community help for moving the remaining official plugins to esm, so we really appreciate your help getting that effort started for this plugin

  • How is this plugin not breaking?

the core of semantic-release is able to load both esm and common-js plugins. is there a specific reason you would expect loading this plugin would be broken?

@csantos1113
Copy link
Author

@travi thanks for replying.

is there a specific reason you would expect loading this plugin would be broken?

I landed here because I saw two versions of @semantic-release/error installed in my node_modules, and found out it was because @semantic-release/github and @semantic-release/npm install latest /error but @semantic-release/git and @semantic-release/changelog install old /error; so first thing that came to my mind was "How is this still working?!" - but thanks for the thread link and it makes sense!, I hadn't seen it before 🙏

please feel free to close this issue (or keep it open for traceability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(esm): converted the package to esm-only csantos1113/git
2 participants
@travi @csantos1113