Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release type should not be case sensitive #496

Closed
Laevos opened this issue Aug 23, 2023 · 2 comments
Closed

Release type should not be case sensitive #496

Laevos opened this issue Aug 23, 2023 · 2 comments

Comments

@Laevos
Copy link

Laevos commented Aug 23, 2023

I'm seeing a bug where if a commit is created with the title Feat: instead of feat:, no release is created. I do see that this is called out, e.g. in this comment, but this seems like potentially unexpected behavior. This also seems to go against the language of the Conventional Commits spec, which states

The units of information that make up Conventional Commits MUST NOT be treated as case sensitive by implementors, with the exception of BREAKING CHANGE which MUST be uppercase.

Apologies if this has been discussed before, I didn't find an indication that it'd been mentioned as a potential issue. Thanks for your time!

@Laevos
Copy link
Author

Laevos commented Aug 23, 2023

Looking at default-release-rules.js, it looks like there are some alternate forms which are accepted, including an all-caps FEAT and a title case Fix, but specifically not a title case Feat. Would a case insensitive match make sense here? Potentially combined with #419, a case-insensitive regex could be used, so the rule could be a commit message which matches, say, /^feat/i?

@travi
Copy link
Member

travi commented Aug 24, 2023

The key detail about the comment that you linked to is that semantic-release is configured to use the angular commit convention by default, not conventional-commits like your other reference. The angular convention is case sensitive. This is not a bug. If you want different rules, you need to use an alternative convention.

@travi travi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants