Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

[Feature] Niffy should accept and test multiple resolutions #13

Open
mousemke opened this issue Sep 15, 2017 · 0 comments
Open

[Feature] Niffy should accept and test multiple resolutions #13

mousemke opened this issue Sep 15, 2017 · 0 comments

Comments

@mousemke
Copy link

mousemke commented Sep 15, 2017

issue: mousemke#2
pr (merged): mousemke#3
pr (open): #14

What needs to get done?

  • niffy should take an object as an option with different resolutions to test all. example:
const niffyTargets = {
  xl: [1205,600],
  l: [965, 600],
  m: [605, 600],
  s: [325, 600]
}

const niffy = new Niffy( url1, url2, { 
    targets: niffyTargets,
    pngPath: path.resolve(process.cwd(), `./niffy`)
 });

in tihs case, it whould output diff images to the following directories:

  • ./niffy/xl
  • ./niffy/l
  • ./niffy/m
  • ./niffy/s

Why does it need to get done?

it saves everyone making their own implementation of the loop and streamlines the process

How do I do it?

loop nightmare over the keys

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant