Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans to provide this utility as a library to be used within other projects #34

Open
kgritesh opened this issue May 31, 2021 · 3 comments · May be fixed by #88
Open

Plans to provide this utility as a library to be used within other projects #34

kgritesh opened this issue May 31, 2021 · 3 comments · May be fixed by #88
Labels
enhancement New feature or request

Comments

@kgritesh
Copy link
Contributor

This is a fantastic utility - kudos for taking the effort to build it. I was wondering if you would be open to the idea of providing this utility also as a library so that any other projects working with code generation can use this to format the generated code.

My use case is that I work on a no-code project where we generate a lot of go code for our customers. The generated code has a huge map which by default is rendered on the same line and is impossible to grok with naked eyes. So I wanted to introduce golines as one of the preprocessing step to break down the map into individual lines. Hence if this utility is available as a library- it would be super useful for me.

I am happy to provide a PR for this - but will require some refactoring and hence wanted to discuss before working on it.
@yolken-segment
Copy link
Contributor

yolken-segment commented Jun 1, 2021 •
edited
Loading

Sure, feel free to submit a PR for this. This would involve moving shortener.go and some of the other utility files to their own package in a subdirectory?

@yolken-segment yolken-segment added the enhancement New feature or request label Jun 1, 2021
@kgritesh
Copy link
Contributor Author

kgritesh commented Jun 7, 2021

@yolken-segment Yes i saw the code and that's what it will take. I will try to work on it as time permits and submit a PR. Thanks for this library and the accompanying blog post.

@strideynet
Copy link

@kgritesh How is this coming along ? I'm happy to raise a PR for this sometime tomorrow if you aren't interested in doing it still ?

@gabe565 gabe565 linked a pull request Oct 28, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Create shorten package gabe565/golines
3 participants
@kgritesh @strideynet @yolken-segment