Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Files Get Stored In User's Documents Directory On Windows #283

Closed
brianmichel opened this issue Nov 29, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@brianmichel
Copy link
Contributor

Describe the bug
When using this SDK on Windows, the temporary files are written to a user's Documents directory. This feels like the wrong place for these documents since they are really temp files and could be purged without much issue. I feel like these should probably be somewhere in AppData for packaged applications, and somewhere in temp otherwise.

This is doubly weird on more modern Windows installs because your user directory is sync'd across machines using OneDrive. So these are going to potentially get copied to other Windows machines that I'm signed into.

To Reproduce
Steps to reproduce the behavior:

  1. Run the test suite
  2. Observe the folder on disk

Expected behavior
I should not see segment information in my documents directory.

Screenshots
image

Platform (please complete the following information):

  • Library Version in use: 1.4.8
  • Platform being tested: Windows (although this problem is likely the same on Linux)
  • Integrations in use: n/a

Additional context
Add any other context about the problem here.

@bsneed
Copy link
Contributor

bsneed commented Nov 29, 2023

I agree. I think the same is true for Mac/linux as well. I've got some storage changes coming up and was planning on making this a configuration option, along with some defaults per-platform. Let me know if you have suggestions for any of the platforms your team supports.

@bsneed
Copy link
Contributor

bsneed commented Mar 11, 2024

Should be fixed now.

@bsneed bsneed closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants