From 2d5c84784983d0999fe907980c97cd183772eb72 Mon Sep 17 00:00:00 2001
From: Pooya Jaferian <pooya.j@gmail.com>
Date: Fri, 26 Nov 2021 00:26:01 -0800
Subject: [PATCH] Exclude destinations QA from the core QA tasks, and make them
 soft fail (#334)

* exclude destination qa from core qa tasks, and add them to a soft fail step

* soft fail on any status code

* force exit the tests at the end

* minor
---
 .buildkite/pipeline.yml | 19 ++++++++++++++++++-
 Makefile                |  4 ++--
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
index ac69ab4f0..dbab48b1d 100644
--- a/.buildkite/pipeline.yml
+++ b/.buildkite/pipeline.yml
@@ -15,7 +15,7 @@ steps:
           paths: ['node_modules/']
           save: true
 
-  - label: ':hammer: QA'
+  - label: ':perfection: QA'
     key: qa
     agents:
       queue: v1
@@ -35,6 +35,23 @@ steps:
       queue: v1
     command: 'bk-snyk'
 
+  - label: ':thisisfine: Destinations QA'
+    key: destinations
+    agents:
+      queue: v1
+    commands:
+      - npm config set "//registry.npmjs.org/:_authToken" $${NPM_TOKEN}
+      - yarn install
+      - yarn add --dev playwright
+      - echo "+++ Running Destinations QA Tests :pray:"
+      - make test-qa-destinations
+    soft_fail:
+      - exit_status: '*'
+    plugins:
+      - ssh://git@github.com/segmentio/cache-buildkite-plugin#v2.0.0:
+          key: "v1.1-cache-dev-{{ checksum 'yarn.lock' }}"
+          paths: ['node_modules/']
+
   # Auto deploys branches
   - label: ':rocket: Release Branch'
     branches: '!master !v*'
diff --git a/Makefile b/Makefile
index c83a3db45..5196a6a9e 100644
--- a/Makefile
+++ b/Makefile
@@ -44,11 +44,11 @@ test-coverage: node_modules ## Runs unit tests with coverage
 .PHONY: test-coverage
 
 test-qa: build-browser ## Runs all QA tests in a single command
-	$(BIN)/jest --runTestsByPath qa/__tests__/*.test.ts --reporters="default" --reporters="<rootDir>/qa/lib/jest-reporter.js" ${args}
+	$(BIN)/jest --runTestsByPath qa/__tests__/*.test.ts --testPathIgnorePatterns qa/__tests__/destinations.test.ts --reporters="default" --reporters="<rootDir>/qa/lib/jest-reporter.js" ${args}
 .PHONY: test-coverage
 
 test-qa-destinations: build-browser ## Runs Destination QA tests. options. DESTINATION=amplitude DEBUG=true
-	$(BIN)/jest --runTestsByPath qa/__tests__/destinations.test.ts --reporters="default" --reporters="<rootDir>/qa/lib/jest-reporter.js" ${args}
+	$(BIN)/jest --forceExit --runTestsByPath qa/__tests__/destinations.test.ts --reporters="default" --reporters="<rootDir>/qa/lib/jest-reporter.js" ${args}
 .PHONY: test-coverage
 
 test-integration: build-browser ## Runs all integration tests in a single command