Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenInfo.Density has wrong type #168

Open
jakekdodd opened this issue Oct 6, 2020 · 0 comments
Open

ScreenInfo.Density has wrong type #168

jakekdodd opened this issue Oct 6, 2020 · 0 comments

Comments

@jakekdodd
Copy link

The Density field on the ScreenInfo struct is typed as an int, but in reality this is often a floating-point value. I believe this was mistyped because the example in the Common Fields spec is—only by coincidence—a whole number.

This leads to json marshaling/unmarshaling errors at runtime:

WARN[0042] error decoding payloadjson: cannot unmarshal number 2.75 into Go struct field ScreenInfo.context.screen.density of type int 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant