Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error returned on empty or invalid write-key #165

Open
mugdha-adhav opened this issue Jul 30, 2020 · 1 comment
Open

No error returned on empty or invalid write-key #165

mugdha-adhav opened this issue Jul 30, 2020 · 1 comment

Comments

@mugdha-adhav
Copy link

If I set an empty or invalid write key while creating a client, it doesn't return any error. Everything goes through and no error is logged.

I tried creating client with both the below methods

1. client := analytics.New(c.Key)
2. client, err := analytics.NewWithConfig(c.Key, analytics.Config{})

But no error is returned even while calling client.Enqueue() or client.Close()

Shouldn't the code return an error if data is not received in Segment? Or even when the client creation is incorrect.

It's assumed that data is sent unless you verify it manually, which is misleading.

@HimanshuS01
Copy link

@mugdha-adhav I am also getting the same issue. Not getting any error on sending empty or invalid write key and I am getting response 200 OK in return. How you have tackled this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants