Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointing sample attributes as experimental factor #1869

Open
floradanna opened this issue May 8, 2024 · 4 comments
Open

Appointing sample attributes as experimental factor #1869

floradanna opened this issue May 8, 2024 · 4 comments
Labels
datahub belgiumHub project

Comments

@floradanna
Copy link
Collaborator

In ISA-JSON compliant experiment, sample attribute(s) can be experimental factor(s).
As researchers, I want to indicate which sample attribute(s) is the experimental factor in study and assay, so that this information can be processed by analysis pipeline

@floradanna floradanna added the datahub belgiumHub project label May 8, 2024
@kdp-cloud
Copy link
Collaborator

@floradanna
Could you specify what the difference is with the parameter_value tag we have in SEEK?
Can you also share if there are constraints to using this tag like:

  • Number
  • Naming
  • Level of the Sample Type it can be used
    ...

@floradanna
Copy link
Collaborator Author

As defined in ISA Model (https://isa-specs.readthedocs.io/en/latest/isamodel.html#study), "A factor corresponds to an independent variable manipulated by the experimentalist with the intention to affect biological systems in a way that can be measured by an assay."

A factor:

  • can be any existing variable in a sample type: a specific parameter value or a characteristics.
  • can be specified at study and/or assay level
  • it should be possible to indicate 0 or more experimental factors at study and/or assay level

@kdp-cloud
Copy link
Collaborator

can be any existing variable in a sample type: a specific parameter value or a characteristics.

If I understand correctly:

  • It's an extra type of annotation for a sample attribute, and not just an extra ISA tag.
  • Only a sample attribute with ISA tag parameter_value or characteristic can be an experimental factor
  • Multiple sample attributes in a sample type can be labeled as 'experimental factor'

Also, I see 'Factor Name' and 'Factor type' in the specifications. Do you want be able to specify these? Or is it enough if you simply specify it's an experimental factor?

@floradanna
Copy link
Collaborator Author

  • correct
  • correct
  • correct

it is enough to be able to simply specify that "this attribute" is an experimental factor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datahub belgiumHub project
Projects
Status: Requirements
Development

No branches or pull requests

2 participants