Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic version implementation #21

Open
rakateja opened this issue Feb 7, 2024 · 2 comments
Open

Semantic version implementation #21

rakateja opened this issue Feb 7, 2024 · 2 comments

Comments

@rakateja
Copy link

rakateja commented Feb 7, 2024

Hi Yuli. Thanks for the great project.

To avoid bugs happen in our application that due to new code or new release of databunker. Could you please implement semantic version for each release instead of always use latest? To make it simpler, I think we can use the pseudo-version number style, i.e

v1.1.0-20191109021931-daa7c04131f5 

Ref: https://go.dev/ref/mod#pseudo-versions
it has three parts

  • base version prefix (i.e v1.1.0)
  • timestamp (i.e 20191109021931)
  • commit hash (i.e daa7c04131f5)

To make it simpler we can alway use the same base version prefix for each version.

How do you think? Thank you.

@stremovsky
Copy link
Contributor

Hello

Thank you for brining this issue.

I implemented a simplified way of versioning for Databunker.

During the code build and container build process, the version is taken from this file:

https://github.com/securitybunker/databunker/blob/master/version.txt

Let me know if this is ok,

Otherwise let's have a chat to understand your requirements.

Yuli

@stremovsky
Copy link
Contributor

stremovsky commented Apr 28, 2024

I made another changes in build.sh script to generate version as you suggested.

Check now:

./databunker --version
Databunker version: 0.8.2-20240428120914-65521a3b9f25

I publish containers with 0.8.2 and latest tags.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants