Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TR num_local_datasets to be set to 0 #857

Open
khurram-ghani opened this issue Jun 19, 2024 · 0 comments
Open

Allow TR num_local_datasets to be set to 0 #857

khurram-ghani opened this issue Jun 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@khurram-ghani
Copy link
Collaborator

Describe the bug
A derived rule should be able to override the num_local_datasets property of BatchTrustRegion and return 0. This use-case is when a rule does not use local-datasets with the regions, and instead manages only global datasets. Returning 0 from this property should mean there are "no local datasets", however this results in a divide-by-0 error in two places in the ask-tell-optimizer:

Trieste should probably explicitly support and document this use-case, and add tests for it.

@khurram-ghani khurram-ghani added the bug Something isn't working label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant