Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SparseVariational throws an error with more than one latent GP. #694

Open
vpicheny opened this issue Feb 13, 2023 · 0 comments
Open

SparseVariational throws an error with more than one latent GP. #694

vpicheny opened this issue Feb 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@vpicheny
Copy link
Collaborator

This check seems incorrect when you have scalar observations, but several latent GPs:
https://github.com/secondmind-labs/trieste/blob/develop/trieste/models/gpflow/models.py#L953

In that case dataset.observations.shape[-1] is one, but q_mu.shape[-1] is equal to num_latent.

Possible fix is to use the likelihood's observation_dim, but I'm not sure it's defined all the time.
@vpicheny vpicheny added the bug Something isn't working label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vpicheny