Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniature improvements #32

Open
1 of 2 tasks
tmos opened this issue May 4, 2014 · 18 comments
Open
1 of 2 tasks

miniature improvements #32

tmos opened this issue May 4, 2014 · 18 comments
Milestone

Comments

@tmos
Copy link
Collaborator

tmos commented May 4, 2014

Here are the improvements that could be done to the thumbnails :

  • proportional cropping available via an option.
  • cropping transparent pictures create a white background instead a black one

Those two improvements can be inspired by this code : http://www.akemapa.com/2008/07/10/php-gd-resize-transparent-image-png-gif/

@tmos
Copy link
Collaborator Author

tmos commented May 4, 2014

white background in case of transparent picture is done.

@Denys06
Copy link

Denys06 commented Jun 2, 2014

Hello, can you say me how can I have proportional cropping of picture please ? I don't found what I need to modify into config.php

Thank you in advance for your help.

@tmos
Copy link
Collaborator Author

tmos commented Jun 2, 2014

Sorry, this feature is not implemented yet, we have to modify the miniature generation code.

@Denys06
Copy link

Denys06 commented Jun 2, 2014

Ok, thank you for your answer.

I hope this feature can be implemented rapidly, I wait it for open my gallery ;)
thank you see you soon

@tmos
Copy link
Collaborator Author

tmos commented Jun 2, 2014

Due to my agenda, don't hope this before one month, except if someone handle this before me.

@Denys06
Copy link

Denys06 commented Jun 30, 2014

Hello tmos,

Do you have news about "proportional cropping available via an option" ?

I look forward to this change. Thank you

@tmos
Copy link
Collaborator Author

tmos commented Jun 30, 2014

Actualy I'm don't have much time nowadays.
I may have time to handle this before end of august, but no promises :-/

@Denys06
Copy link

Denys06 commented Jun 30, 2014

Ok, I hope...

thank you for your answer tmos

@Denys06
Copy link

Denys06 commented Aug 29, 2014

Hello tmos

I come with enthusiasm at the end of August to see if you have the time to develop the latter part of the script regarding : "proportional cropping available via an option".

I'm still looking for this feature and I would be really happy to see integrated into the gallery.

Thank you in advance
Denys

@tmos
Copy link
Collaborator Author

tmos commented Aug 29, 2014

Hello dear Denis,

I'm not really involved in MiniGal anymore. Actually, I'm here mainly to have a look on pull-requests, but I don't have any motivation for coding here anymore.

A lot of capable people (aka, other devs) come here to ask, and take, but very few tries to give back some help. So I have to confess that it don't help me to have passion to involve here. Sorry :-/

I'm not really a php-dev, so all the work I can bring here involve a lot of time of search and tests, so I can't bring a quick and efficient fix. Any native php-dev can probably do all those features in few hours, but nobody want to take this time.

I was mainly here to bring fresh air for the interface, and see pull requests. At last, I made RSS feeds too (with help, thanks again to concerned people), but I don't have motivation and knowledge to go further.

As an open-source developer, we don't get any retribution other than "thanks", and the pleasure to learn things from users and other devs. When you don't get one or the other, it is really hard to keep going.

I hope you understand, I'm very sorry for the hope I may gave to you for this feature.

To all devs who read this : don't hesitate to do some fixes here, I'll have a look on any pull request.

@Denys06
Copy link

Denys06 commented Aug 30, 2014

I'm really disappointed that the proposed development of miniature can not be finished but I thank you for your candor and your explanation. If someone comes along and can give me the script for thumbnail "proportional" it would be really nice because I need only this functionality so that I can fully enjoy this script, otherwise I'll have to find a new gallery, but it really bother me a lot ... :(

@nodiscc
Copy link
Contributor

nodiscc commented Aug 30, 2014

proportional cropping available via an option

what is this exactly? I could have a look at it but I don't understand what this is supposed to do.
A screenshot of the desired feature would be nice.

@Denys06
Copy link

Denys06 commented Aug 31, 2014

Hello and thank you for your answer

Actually, the thumbnails are a square
http://www.slotcar-union.com/gallery/createthumb.php?filename=photos/Scalextric/folder.jpg&size=220

I want to make a proportional rectangle for not have cut pictures
http://hpics.li/6c836f2

I think changes need to do this in createthumb.php, but I do not know how ...

@tmos
Copy link
Collaborator Author

tmos commented Aug 31, 2014

Exactly, the goal is to display a miniature of the picture that is not cropped.

Just smaller, with the same horizontal width each time.

With this, the miniature grid will not be very regular (pictures well have the same width, but not the same height as they keep their proportions), but with few js we can make a reorganisation pinterest-like, so it fits nicely.

Thank noddisc for having a look at this :)

@Denys06
Copy link

Denys06 commented Oct 7, 2014

Hello,
Someone in github can make this modification please ?

@nodiscc
Copy link
Contributor

nodiscc commented Oct 18, 2014

For your information I have given up on this for now. I have little interest in this feature, and the lightbox replacement problem seems more important.

@Denys06
Copy link

Denys06 commented Oct 18, 2014

Ok ;(
I continue to follow this topic for the day someone can make this modification

Thank you

@tmos tmos modified the milestone: 1.0 Nov 9, 2014
@Denys06
Copy link

Denys06 commented Jul 6, 2015

Hello :)

Do you have new about the function "proportional cropping available via an option."
Please someone can help me to improve this feature on my website because I really need it :

http://www.slotcar-union.com/fr/content/15-plans-seuls

watch all my miniatures are cut :(

@tmos tmos mentioned this issue Jul 4, 2016
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants