Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requrest Unicode support (wrong thumbnails under multiple Unicode directories) #126

Open
briancblog opened this issue Dec 14, 2018 · 1 comment

Comments

@briancblog
Copy link

Hello,

Thanks for your GREAT PHP photo gallery!

Some directories are named in Unicode chars. For instance we have 2 sub-directories under one directory:

root/dir/sub-dir1/1.jpg
root/dir/sub-dir2/1.jpg

If Unicode directory names of sub-dir1 and sub-dir2 are equal in chars length, the second thumbnail of "root/dir/sub-dir2/1.jpg" will just display the previous thumbnail of "root/dir/sub-dir1/1.jpg" wrongly. I checked the thumbs folder, and there is only 1 image of "root_dir_____1.jpg".

This issue does not exist in ANSI directory names.

Could you please improve MinigalNano to support UNICODE?

Thank you!
Brian

@briancblog
Copy link
Author

I can temporarily resolve this issue by comment the partial code in createthumb.php. The system will serve existing thumbnail file by default, and I disabled it by commenting. This will affect performance and is not a perfect resolution. Every time when one image is accessed, the system will generate the thumbnail again, which means cached thumbnails are disable.

So I am requesting to resolve this issue.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant