Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pictures data binding #112

Open
Draky50110 opened this issue Jun 8, 2016 · 5 comments
Open

Pictures data binding #112

Draky50110 opened this issue Jun 8, 2016 · 5 comments
Milestone

Comments

@Draky50110
Copy link

Hello.

Trying to add a comment file for one imagE.
Name is ok but I put HTML language in it and... it is displayed as plain text.

So is it really HTML ?
What exactly can we put in image_filename.hml ?
What is "title:comment" tag ?

@tmos tmos mentioned this issue Jul 4, 2016
14 tasks
@tmos
Copy link
Collaborator

tmos commented Jul 5, 2016

Hi @Draky50110

TL;DR : you can't setup proper html, it's filtered.

But, this issue is just revelant of a bigger problem : we really need to have a better system for the pictures comments.

Today, we have a mix of what you use here : a file with pic_name:comment, and also pic_name.ext.html.

None of them is easily usable, and I think, not very functional.

We should get rid of those old features, and setup a new and easy to use way of binding data to pictures.

I think that a CSV-like file would be a nice option.

So every picture would be identified by its name, in the first col, and we could get every data we want, in the other columns.
We could setup some basic data (id, title, description), and let people use any data they want in their themes (lat, long, people_name, date, place,...). All of those informations could be used theme-side, without any modification of minigal code !

One CSV per folder could be a nice way of spliting data for performances.

What do you think about that ?

(ping to some people that may be interested on this issue : @nodiscc @Aldarone @sebsauvage )

@tmos tmos changed the title HTM comment file for image Pictures data binding Jul 5, 2016
@tmos tmos added this to the 1.0 milestone Jul 5, 2016
@Draky50110
Copy link
Author

Personnaly, I don't have any idea about this :p
Was just trying to add comments for some pictures and never succeed.

@tmos
Copy link
Collaborator

tmos commented Jul 5, 2016

No problem, I just used your issue to go deeper on the issue origin. I think you can consider the current state of comments as broken if it doesn't work as-is.

Will be fixed in a near future :)

@Draky50110
Copy link
Author

Ok.
I keep following notifications in this issue ;)
Thanks :D

@nodiscc
Copy link
Contributor

nodiscc commented Jul 7, 2016

@tmos I think this is good idea; I'm just unsure about CSV as a storgae format. IMHO the requirements for the comments file should be:

  • 1 comment file per directory
  • must be easily human-readable/writeable
  • parsing the data should ideally rely on well known PHP libs (php5-json?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants