Apparent get_connection_pool race condition, object has no attribute 'connection_identifier'

[graemegcox]

I have long been using django-redis-cache with py-redis and BlockingConnectionPool in production. I see this error a very small fraction of the time.

I suspect that the following lines of code in get_connection_pool() need to be swapped, so that another thread that accesses _connection_pools will not see the connection before the connection_identifier attribute has been added.

self._connection_pools[connection_identifier] = pool
pool.connection_identifier = connection_identifier