Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull all of the colours out into the resources #73

Open
sebheron opened this issue Jan 15, 2021 · 1 comment
Open

Pull all of the colours out into the resources #73

sebheron opened this issue Jan 15, 2021 · 1 comment

Comments

@sebheron
Copy link
Owner

I'm thinking we should take all the colours and put them into a separate resources file.
My thinking is we can then work on adding in dark mode theming, hacker theming, halo theming, heretic theme?
Maybe this is even an opportunity to add the ability to customize themes yourself and export them, and import other peoples themes.
I've split this up for now into 2 Issues as I don't know how long it'd take. I thought I could take the brunt and do this issue, compiling all the colours into a resource and then you could take other work of implementing a colour themer thingy if you fancy it? Think it will be some interesting work.

@aidanhorton
Copy link
Collaborator

Feel free to do both! I've got other things I can pick up if you fancy doing it 😉
At the very least the colours need to be extracted away from each separate control and into some form of centralized system - I guess we can leave it with whoever implements this to decide the way they want to architect it - I don't think you can really go wrong with any method here.

Approved!

@sebheron sebheron added this to the Second release milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants