Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

only case sensitive to ratio/partial_ratio? #182

Open
ZhensongQian opened this issue Nov 10, 2017 · 4 comments
Open

only case sensitive to ratio/partial_ratio? #182

ZhensongQian opened this issue Nov 10, 2017 · 4 comments

Comments

@ZhensongQian
Copy link

ZhensongQian commented Nov 10, 2017

  • for ratio/partial_ratio, it is case sensitive
  • but for token_sort_ratio/token_set_ratio is case insensitive
    would be better to make them consistent?
>>> fuzz.ratio("this is a test", "this is a test!")
97
>>> fuzz.ratio("this is a test", "this is a TEST!")
69
>>> fuzz.partial_ratio("this is a test", "this is a test!")
100
>>> fuzz.partial_ratio("this is a test", "this is a TEST!")
71
>>> fuzz.token_sort_ratio("fuzzy wuzzy was a bear", "wuzzy fuzzy was a bear")
100
>>> fuzz.token_sort_ratio("fuzzy wuzzy was a bear", "wuzzy fuzzy was a BEAR")
100
>>> fuzz.token_set_ratio("fuzzy was a bear", "fuzzy fuzzy was a bear")
100
>>> fuzz.token_set_ratio("fuzzy was a bear", "fuzzy fuzzy was a BEAR")
100
@josegonzalez
Copy link
Contributor

josegonzalez commented Nov 10, 2017

Probably yes, but would have to be a minor release. Can you submit a pull request with this change, making it always case sensitive? I can review/merge/release it for you :)

@ZhensongQian
Copy link
Author

@josegonzalez Created the pull request #185, remove the force of "lowercase". Ready for review.

@ZhensongQian
Copy link
Author

@josegonzalez any chance to have an update soon? thanks.

@josegonzalez
Copy link
Contributor

Left a comment :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants