defaultChecked property does not work when used in radio children components

[diogob]

Steps to reproduce:

1. Use the example: test-examples/field-with-radio-children.
2. Tweak the radio group to introduce a defaultChecked property.

                  <RadioGroup>
                    <RadioWrapper>
                      <Radio value="google" defaultChecked={true} />
                      <Label>Google</Label>
                    </RadioWrapper>
                    <RadioWrapper>
                      <Radio value="fromAFriend" />
                      <Label>From a friend</Label>
                    </RadioWrapper>
                  </RadioGroup>

3. When the example is updated in the browser there are no checked radios

Expected result

The radio marked with defaultChecked should be selected.

Technical details

It seems that we are properly setting the defaultChecked and then resetting in the useEffect hook used to apply defaults.

[danielweinmann]

This is tricky. I don't think we're supposed to pass defaultChecked or defaultValues to fields directly when using React Hook Form. As far as I can tell, we should register the same field for all radio buttons instead (which Remix Forms does automatically).

[danielweinmann]

@diogob and I discussed it, and we won't try to fix this now because this is not a bug: it's just how RHF works.

However, we'll leave the issue open because we might want to remove the prop from the components in v2.