Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitdir overwrites files without confirmation #33

Open
alichtman opened this issue Jan 11, 2024 · 0 comments · May be fixed by #34
Open

gitdir overwrites files without confirmation #33

alichtman opened this issue Jan 11, 2024 · 0 comments · May be fixed by #34

Comments

@alichtman
Copy link

alichtman commented Jan 11, 2024 •
edited

Thanks for this tool! I accidentally overwrote some of my files earlier, and I think this is a preventable mistake.

https://github.com/sdushantha/gitdir/blob/0c071cca295907df216c93251803f5076cd82165/gitdir/gitdir.py#L103C17-L103C43

You can reproduce the problem with:

$ cd /tmp

$ gitdir https://github.com/sdushantha/gitdir/tree/master/gitdir
Downloaded: __init__.py
Downloaded: __main__.py
Downloaded: gitdir.py
✔ Download complete

$ echo "will be deleted" > gitdir/__main__.py

$ gitdir https://github.com/sdushantha/gitdir/tree/master/gitdir
Downloaded: __init__.py
Downloaded: __main__.py
Downloaded: gitdir.py
✔ Download complete

$ head gitdir/__main__.py
from .gitdir import main

main()

I'd propose adding a prompt to confirm, and a --force,-f flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prompt before overwriting files, some error handling, and refactoring alichtman/gitdir
1 participant
@alichtman