Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make http::client::make_request() abortable #2409

Closed
xemul opened this issue Aug 27, 2024 · 0 comments · Fixed by #2410
Closed

Make http::client::make_request() abortable #2409

xemul opened this issue Aug 27, 2024 · 0 comments · Fixed by #2410
Assignees

Comments

@xemul
Copy link
Contributor

xemul commented Aug 27, 2024

Currently the method can block in one of 4 places:

  • connecting to server
  • waiting for a connection from pool
  • writing request to socket
  • reading response from server

Either of the steps should be abortable. One of the use-cases is to time-out the request (see #2304). Another -- abort of large file upload in case this upload by user request (e.g. cancelling backup process for whatever reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant