-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux_perf_event fails on aarch64 since exclude_idle is set #2298
Comments
bhalevy
added a commit
to bhalevy/seastar
that referenced
this issue
Jun 18, 2024
Commit 93f19d3 added `exclude_idle = 1` to `linux_perf_event`. However, as reported in scylladb/scylladb#19227 (comment), `exclude_idle` is not supported on ARM platforms. This change sets `exclude_idle` only on known-to-work architectures (presently, it's only x86_64), assuming it is initialized to 0 as all other unset bitfields in `perf_event_attr`. Fixes scylladb#2298 Signed-off-by: Benny Halevy <[email protected]>
avikivity
added a commit
that referenced
this issue
Jul 4, 2024
Commit 93f19d3 added `exclude_idle = 1` to `linux_perf_event`. However, as reported in scylladb/scylladb#19227 (comment), `exclude_idle` is not supported on ARM platforms. This change sets `exclude_idle` only on known-to-work architectures (presently, it's only x86_64), assuming it is initialized to 0 as all other unset bitfields in `perf_event_attr`. Fixes #2298 Closes #2295 * github.com:scylladb/seastar: linux_perf_event: exclude_idle only on x86_64 linux_perf_event: add make_linux_perf_event
ptrsmrn
pushed a commit
to ptrsmrn/seastar
that referenced
this issue
Jul 17, 2024
Commit 93f19d3 added `exclude_idle = 1` to `linux_perf_event`. However, as reported in scylladb/scylladb#19227 (comment), `exclude_idle` is not supported on ARM platforms. This change sets `exclude_idle` only on known-to-work architectures (presently, it's only x86_64), assuming it is initialized to 0 as all other unset bitfields in `perf_event_attr`. Fixes scylladb#2298 Signed-off-by: Benny Halevy <[email protected]>
lovio
pushed a commit
to lovio/seastar
that referenced
this issue
Aug 30, 2024
Commit 93f19d3 added `exclude_idle = 1` to `linux_perf_event`. However, as reported in scylladb/scylladb#19227 (comment), `exclude_idle` is not supported on ARM platforms. This change sets `exclude_idle` only on known-to-work architectures (presently, it's only x86_64), assuming it is initialized to 0 as all other unset bitfields in `perf_event_attr`. Fixes scylladb#2298 Signed-off-by: Benny Halevy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As seen in scylladb/scylladb#19227 (comment)
exclude_idle
is not supported on ARM platforms causing theperf_event_open
system call to fail.The documentation in https://man7.org/linux/man-pages/man2/perf_event_open.2.html says:
FWIW, although this applies to several bitfields in the linux
perf_event_attr
, we've only seen an issue now withexclude_idle
on arm.The text was updated successfully, but these errors were encountered: