-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use undeprecated functions in c-ares #2197
Comments
see also c-ares/c-ares@5fd3fc3 |
It's worth noting that among the deprecated functions there is
|
In v1.28.1, C-Ares marked some of their functions as deprecated causing compilation errors in Seastar. This commit makes the compiler ignore the used functions until we fix it properly by using recommended (undeprecated) library functions. Refs scylladb#2197
c-ares marked some APIs deprecated in 1.28.1. in this change, we conditionally use the undeprecated APIs when they are available. please note, we don't specify the minimal supported c-ares version in our building system. in which, ares_fds() and ares_process() are not changed yet, because we need to change the way how to poll the events for name resolution. this would need more thoughts before moving forward. Refs scylladb#2197 Signed-off-by: Kefu Chai <[email protected]>
c-ares marked some APIs deprecated in 1.28.1. in this change, we conditionally use the undeprecated APIs when they are available. please note, we don't specify the minimal supported c-ares version in our building system. in which, ares_fds() and ares_process() are not changed yet, because we need to change the way how to poll the events for name resolution. this would need more thoughts before moving forward. Refs scylladb#2197 Signed-off-by: Kefu Chai <[email protected]>
c-ares marked some APIs deprecated in 1.28.1. in this change, we conditionally use the undeprecated APIs when they are available. please note, we don't specify the minimal supported c-ares version in our building system. in which, ares_fds() and ares_process() are not changed yet, because we need to change the way how to poll the events for name resolution. this would need more thoughts before moving forward. Refs scylladb#2197 Signed-off-by: Kefu Chai <[email protected]>
c-ares marked some APIs deprecated in 1.28.1. in this change, we conditionally use the undeprecated APIs when they are available. please note, we don't specify the minimal supported c-ares version in our building system. in which, ares_fds() and ares_process() are not changed yet, because we need to change the way how to poll the events for name resolution. this would need more thoughts before moving forward. Refs #2197 Signed-off-by: Kefu Chai <[email protected]> Closes #2200
@bhalevy see the commit message of 47bfd73
these two APIs were deprecated. but we have not replaced them yet. |
c-ares marked some APIs deprecated in 1.28.1. in this change, we conditionally use the undeprecated APIs when they are available. please note, we don't specify the minimal supported c-ares version in our building system. in which, ares_fds() and ares_process() are not changed yet, because we need to change the way how to poll the events for name resolution. this would need more thoughts before moving forward. Refs scylladb#2197 Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2200
c-ares v1.28.1 deprecated a bunch of functions. for instance,
ares_gethostbyname()
is deprecated in favor ofares_getaddrinfo()
The text was updated successfully, but these errors were encountered: