Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional parameter deprecation notices in PHP 8 #578

Open
iandunn opened this issue Aug 31, 2022 · 1 comment
Open

Optional parameter deprecation notices in PHP 8 #578

iandunn opened this issue Aug 31, 2022 · 1 comment

Comments

@iandunn
Copy link

iandunn commented Aug 31, 2022

> wp plugin list
Deprecated: Optional parameter $formdata declared before required parameter $nonce is implicitly treated as a required parameter in wp-content/plugins/posts-to-posts/vendor/scribu/scb-framework/Forms.php on line 65
Deprecated: Optional parameter $file declared before required parameter $args is implicitly treated as a required parameter in wp-content/plugins/posts-to-posts/vendor/scribu/scb-framework/Cron.php on line 24
+----------------------------------+----------+--------+---------+
| name                             | status   | update | version |
+----------------------------------+----------+--------+---------+
| posts-to-posts                   | active   | none   | 1.7     |

https://php.watch/versions/8.0/deprecate-required-param-after-optional

Related #576

@hirasso
Copy link

hirasso commented Sep 21, 2022

These deprecations are actually inside scb-framework, this plugin depends on.

I created a PR to fix them over there. As soon as that is merged, we can update the composer version of scb-framework for wp-posts-to-posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants