Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects are not scoped to their clip in a channel #120

Open
qchenevier opened this issue Jul 21, 2020 · 0 comments
Open

Effects are not scoped to their clip in a channel #120

qchenevier opened this issue Jul 21, 2020 · 0 comments

Comments

@qchenevier
Copy link
Contributor

Using this example:

const session = new scribble.Session();
const effect = new Tone.AutoWah({Q: 6}).toDestination()
const effect2 = new Tone.AutoFilter().toDestination()
session.createChannel({
  instrument: "Synth",
  clips: [
    { pattern: 'x____x____', notes: 'C3 C3', effects: effect },
    { pattern: 'x____x____', notes: 'C3 C3', effects: effect2 },
    { pattern: 'x____x____', notes: 'C3 C3' },
  ],
});

The 3 clips are the same, they all have both effects applied, even the 3rd clip here which should be without an effect.

Note: Here, I connect manually the effects to Destination, using toDestination(), due to #119 but that needs to be fixed. So in offline rendering, in this case, no effects are applied at all !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant