-
Notifications
You must be signed in to change notification settings - Fork 512
How to make a Splash release
Mikhail Korobov edited this page Feb 20, 2016
·
25 revisions
(these notes are for maintainers)
Check before release:
- changelog is up-to-date;
- Tests are passing on Travis;
- Splash build is successful on DockerHub;
- Splash-Jupyter build is successful on DockerHub.
- Run
python setup.py sdist
and check that all files are included; pay special attention to css/js/Lua files.
Update version numbers in:
TODO: automate it with bumpversion
Commit version number changes (e.g. 'bump version to 2.1').
Add git tag to the last commit; it should be exactly the same as new version number (e.g. 2.1).
After versions are updated, make a new PyPI release:
python sdist upload
python bdist_wheel upload
Then update automated Splash Docker builds:
- Go to https://hub.docker.com/r/scrapinghub/splash/~/settings/automated-builds/
- Find a row with Docker Tag Name == 'latest'; change tag name to latest version number (e.g. 2.1); click "Save Changes" and then "Trigger Build".
-
Create a new automated build for the release: Docker tag should be equal to git tag (e.g. 2.1 and 2.1).(this should be handled by new DockerHub 'sourceref' feature')
Then update Splash-Jupyter Docker builds:
- Create a new git branch named A.B.x for the new release (e.g. 2.1.x).
- Add a change like this to this branch - update FROM directive in dockerfiles/splash-jupyter/Dockerfile to use latest Splash release version;
- Go to https://hub.docker.com/r/scrapinghub/splash-jupyter/~/settings/automated-builds/;
- Find a row with Docker Tag Name == 'latest'; change branch name to match latest version number (e.g. 2.1.x); click "Trigger Build".
- Create a new automated build for the release: git branch should be the release branch (e.g. 2.1.x), docker tag name should be version number (e.g. 2.1), Dockerfile location should be "/dockerfiles/splash-jupyter".
TODO: use new DockerHub sourceref feature