-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't parse dates as prices #4
Comments
Can we find a universal date parser lib and filter the matches? If that's a good approach I would like to work on it. |
@GodSaveTheDucks there is https://github.com/scrapinghub/dateparser, but I think it is better not to follow this approach, for performance and simplicity reasons. It is not a job of price-parser to classify prices vs dates with a highest possible quality; the idea is to have some additional pre-filter, which is fast & reliable, but likely not complete. |
|
@kmike tests fixed. Take a look, please. |
Dates like
July, 2004
or15.08.2017
should not be parsed as prices, we should detect them and return amount=None currency=None.The text was updated successfully, but these errors were encountered: