Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First non-empty result should be extracted in case of OpenGraph #117

Closed
kmike opened this issue Jun 10, 2019 · 2 comments · May be fixed by #120
Closed

First non-empty result should be extracted in case of OpenGraph #117

kmike opened this issue Jun 10, 2019 · 2 comments · May be fixed by #120
Labels
bug

Comments

@kmike
Copy link
Member

kmike commented Jun 10, 2019 •
edited
Loading

#115 was a step in a right direction (prefer first results), but it seems it is not the whole solution, as empty results should not be prioritized.

E.g. on https://www.triganostore.com/tente-de-camping-raclet-bora-4.html there are two og:description values, the first one is empty. https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fwww.triganostore.com%2Ftente-de-camping-raclet-bora-4.html shows that a non-empty one is extracted.
@kmike kmike mentioned this issue Jun 10, 2019
Merged
@Gallaecio Gallaecio added the bug label Jun 14, 2019
@croqaz croqaz mentioned this issue Jul 16, 2019
Open
@ivanprado ivanprado mentioned this issue Jul 26, 2019
Merged
@ivanprado
Copy link
Contributor

Proposed a fix here: #121

@ivanprado
Copy link
Contributor

Fixed on #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore empty OpenGraph props scrapinghub/extruct
3 participants
@kmike @Gallaecio @ivanprado