Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom and Pan features for Smith Chart #928

Open
Sionwage opened this issue Jun 29, 2023 · 6 comments
Open

Zoom and Pan features for Smith Chart #928

Sionwage opened this issue Jun 29, 2023 · 6 comments
Labels
Feature Request Wished Feature

Comments

@Sionwage
Copy link

It would be nice to define a normalized impedance and zoom left to enlarge a region of the smith chart.

image

@Sionwage Sionwage added the Feature Request Wished Feature label Jun 29, 2023
@cafeclimber
Copy link
Contributor

@jhillairet if we're still interested in separating out the GUI stuff into a separate repo for 1.0, I think it would make sense to move to pyqtgraph. That would help with something like this as well as e.g. fast updates from a VNA (if it's possible to query data that fast). I did a polar plot implementation for PyChamber and think it wouldn't be too much to build on that for a smith chart

@Sionwage
Copy link
Author

Is there a post or document outlining the envisioned modules to utilize for plotting?

@cafeclimber
Copy link
Contributor

I don't believe there's any concrete plans about changes to plotting. There is a module called qtapps? that contains widgets that can be added to apps using Qt to make a GUI. I think with moving that module to a separate repo provides the opportunity to consider other plotting libraries.

With your original question, are you able to zoom in using matplotlib's zoom to rectangle button?

@Sionwage
Copy link
Author

Actually I didn't know about ipympl but that works perfectly to move and zoom.

I just installed it and added "%matplotlib ipympl" to the top of the jupyter lab cell I was running.

I do need to figure out how to enhance the axis density on zooming in for Smith Chart plots.

@jhillairet
Copy link
Member

@jhillairet if we're still interested in separating out the GUI stuff into a separate repo for 1.0, I think it would make sense to move to pyqtgraph. That would help with something like this as well as e.g. fast updates from a VNA (if it's possible to query data that fast). I did a polar plot implementation for PyChamber and think it wouldn't be too much to build on that for a smith chart

Eventually, letting users the possibility to use a graphics backend or another.

@mhuser
Copy link
Collaborator

mhuser commented Mar 9, 2024

#1041 might be of interest, though it does not fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Wished Feature
Projects
None yet
Development

No branches or pull requests

4 participants