Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network.write_touchstone doesn't write the noise information #379

Open
FournierVincent opened this issue Jul 31, 2020 · 1 comment
Open
Labels
Improvements Improvements of existing feature Touchstone concerning Touchstone formats reading/writing

Comments

@FournierVincent
Copy link
Contributor

The Network.write_touchstone does write the S parameters but not the noise parameters as specified in the touchstone spec.
https://ibis.org/connector/touchstone_spec11.pdf

    nw = rf.Network(f=[76.0],s=[[[0,1 ],[0,1]]],z0=[[50, 50]],name='noisynw',f_unit='GHz')
    nw.set_noise_a(nw.frequency, 3.3, 0.2+0.2j, 250 )
    nw.noisy
    nw.write_touchstone(return_string=True)

'!Created with skrf (http://scikit-rf.org).\n# GHz S RI R 50.0 \n!freq ReS11 ImS11 ReS21 ImS21 ReS12 ImS12 ReS22 ImS22\n76.0 0.0 0.0 0.0 0.0 1.0 0.0 1.0 0.0\n'

@jhillairet jhillairet added the Improvements Improvements of existing feature label Jul 31, 2020
@FournierVincent
Copy link
Contributor Author

The methods for plotting (on a smith chart or ni rectangular) the noise parameters g_opt, nfmindb, g_opt, rn are missing.
Idem for NetworkSet.

@jhillairet jhillairet added the Touchstone concerning Touchstone formats reading/writing label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvements Improvements of existing feature Touchstone concerning Touchstone formats reading/writing
Projects
None yet
Development

No branches or pull requests

2 participants