Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help migrating to scikit-build-core: No "FindCython.cmake" found in CMAKE_MODULE_PATH #767

Open
ajfriend opened this issue Jun 13, 2024 · 4 comments

Comments

@ajfriend
Copy link

Hi folks, I'm trying to migrate h3-py from scikit-build to scikit-build-core: uber/h3-py#378

I'm currently running into an issue: No "FindCython.cmake" found in CMAKE_MODULE_PATH

I was wondering if anyone recognized what was going on, and could point me towards any ideas on how to resolve it.

Also, I've noticed in the docs things like "Scikit-build-core does not include helpers for F2Py or Cython like scikit-build classic yet. These will be carefully reimagined soon." Since our project uses Cython, does that mean we should avoid scikit-build-core for now because things just won't work, or does it mean that I'll just have to do a few things manually (and what would that look like)?

@LecrisUT
Copy link
Collaborator

There are examples in the getting started page. What is lacking are helper functions that would automate those steps.

@henryiii
Copy link
Collaborator

Work is at https://github.com/scikit-build/cython-cmake. Though you can just copy the old file in and use it, or do it manually (which isn't too hard, and works without scikit-build-core). Examples will help us shape the design of the new module, which we'd like to propose upstream once it's good enough.

@ajfriend
Copy link
Author

Thanks! I think we've got things working here: uber/h3-py#378

We weren't able to get the old files working, so we ended up writing things by hand for now. Once the helpers are ready, I think we'd be happy to migrate.

Is there anything we can do to make this a more useful example use case for you? Also, if you have any general suggestions on better ways to use the tool or organize our current build, we'd be more than happy to hear!

@henryiii
Copy link
Collaborator

Feel free to check on scikit-build/cython-cmake#19 and see if that would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants