Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames now that we have a build section #747

Closed
henryiii opened this issue May 15, 2024 · 5 comments · Fixed by #793
Closed

Renames now that we have a build section #747

henryiii opened this issue May 15, 2024 · 5 comments · Fixed by #793
Milestone

Comments

@henryiii
Copy link
Collaborator

I'd like to rename:

  • cmake.targets -> build.targets
  • cmake.verbose -> build.verbose

Old will work but be deprecated (minimum-version based).

@LecrisUT
Copy link
Collaborator

cmake.verbose would be useful to separate verbose for configure and build stage

@henryiii henryiii added this to the v0.10.0 milestone Jun 7, 2024
@henryiii
Copy link
Collaborator Author

henryiii commented Jul 1, 2024

Probably also a configure section too, see #790. Either config or configure.

@henryiii
Copy link
Collaborator Author

henryiii commented Jul 2, 2024

I'm not sure what would go in config, though. cmake.args mirrors CMAKE_ARGS better, and we think of it as args to cmake more than configure-time arguments. configure.preset sounds good, though.

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jul 2, 2024

Why not have cmake.args be alias to config.args? From CMake point of view it kinda mirrors the cmake without any option is implicitly configure. Would fit more naturally with build.args.

But also tool.scikit-build.config.xxx or tool.scikit-build.cmake.config.xxx? I don't think the latter is too verbose when it is being used within a group tool.scikit-build.cmake

@henryiii
Copy link
Collaborator Author

henryiii commented Jul 2, 2024

I don't like the idea of a permeant alias. Then you have to solve the question of what to do if both are specified. Though I do like the potential symmetry there somewhat, but these are cmake args as well, while build args are not cmake args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants