Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL scheme config auto-setting may cause errors in certain deployments #682

Open
brassy-endomorph opened this issue Oct 10, 2024 · 0 comments

Comments

@brassy-endomorph
Copy link
Collaborator

Describe the bug

We set the URL scheme to https if the SERVER_NAME config is set. This may cause bugs with .onion addresses or IP addresses where users land on http:// and then every link that's generated is https://

# Handle the tips domain for profile verification
app.config["SERVER_NAME"] = os.getenv("SERVER_NAME")
app.config["PREFERRED_URL_SCHEME"] = "https" if os.getenv("SERVER_NAME") is not None else "http"

Suggested Fix

May this an independently configurable variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant