Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding tests from npm package distribution #72

Closed
char0n opened this issue Nov 5, 2024 · 6 comments
Closed

Excluding tests from npm package distribution #72

char0n opened this issue Nov 5, 2024 · 6 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@char0n
Copy link

char0n commented Nov 5, 2024

npm package of scarf-js does include test/* directory which is intended for development purposes only. It seems to causing issues with yarn + vitest combo.

This was originally reported in swagger-api/swagger-ui#10197. I assume that because of #3, scarf is already disabled, but vitest from whatever reason tries to read tests from the installed scarf.js package.

@aviaviavi aviaviavi added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 5, 2024
@aviaviavi
Copy link
Contributor

Thanks for reporting @char0n, we will get this fixed ASAP

@char0n
Copy link
Author

char0n commented Nov 6, 2024

@aviaviavi any ETA on new 1.4.0 release?

@aviaviavi
Copy link
Contributor

@char0n it's live as a next release! Let us know if you are still seeing issues.

@char0n
Copy link
Author

char0n commented Nov 7, 2024

@aviaviavi thanks, utilizing 1.4.0 version, will ping if any additional issues.

@char0n
Copy link
Author

char0n commented Nov 8, 2024

I can confirm that the issue is resolved in v1.4.0 - swagger-api/swagger-ui#10197 (comment)

@aviaviavi
Copy link
Contributor

aviaviavi commented Nov 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants