Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show[Throwable] #2033

Open
NeQuissimus opened this issue Jan 7, 2019 · 1 comment
Open

Show[Throwable] #2033

NeQuissimus opened this issue Jan 7, 2019 · 1 comment
Labels
good first issue scalaz7 Scalaz 7.x

Comments

@NeQuissimus
Copy link
Member

I just came across the fact that a Show[Throwable] exists.

  1. It is not wired up into import Scalaz._, one needs to import scalaz.std.java.throwable._
  2. It discards the stack trace entirely.

What's going on with this? :D
Is it OK if I fix both of these (for 7.2 and 7.3)?
@NeQuissimus NeQuissimus added the scalaz7 Scalaz 7.x label Jan 7, 2019
@NeQuissimus NeQuissimus mentioned this issue Jan 20, 2019
Closed
@Milyardo
Copy link
Contributor

Milyardo commented Feb 4, 2019

Show[Throwable] may exists but should it? I can't remember of stack trace walking has any side effects in it.

lamusique added a commit to lamusique/scalaz that referenced this issue Jun 27, 2019
@lamusique
Merge the issue, Show[Throwable] scalaz#2033 into the latest version.
daf5532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue scalaz7 Scalaz 7.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Milyardo @hobwekiva @NeQuissimus