Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatize yarn.lock or remove it #519

Open
nulls opened this issue Apr 3, 2023 · 2 comments
Open

Automatize yarn.lock or remove it #519

nulls opened this issue Apr 3, 2023 · 2 comments
Labels
enhancement New feature or request infrastructure question Further information is requested

Comments

@nulls
Copy link
Member

nulls commented Apr 3, 2023

          > shouldn't it be automatically? @nulls

we have it as a separate task in save-cloud, but we don't have such in save-cli

honestly, I don't understand why we need yarn.lock in save-cli: it doesn't have JS executable artifact, only as a library (and it's a pure kotlin app). Will create an issue for it (if we need the yarn.lock, will create a task for it as in save-cloud),

And still it can fail: even in save-cloud, the task kotlinUpgradeYarnLock is separate and if JS dependency changed by upgrading the kolin (as we see it here) -- it fails

Originally posted by @nulls in #518 (comment)

@nulls nulls added enhancement New feature or request question Further information is requested infrastructure labels Apr 3, 2023
@nulls
Copy link
Member Author

nulls commented Apr 3, 2023

can we unify updates in JS and in kotlinUpgradeYarnLock into the single action for renovate bot?

@petertrr
Copy link
Member

petertrr commented Apr 3, 2023

Without a lockfile, yarn/npm will always resolve version ranges each time build is performed. Some time ago, there was an incident when this setup caused all Kotlin installations to download a certain dependency version that contained malware. Since then, having yarn.lock in Kotlin projects is both enabled by default and recommended.

Here is the blog post about the original issue: https://blog.jetbrains.com/kotlin/2021/10/important-ua-parser-js-exploit-and-kotlin-js/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants