Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer the repository to @sass organization? #108

Closed
dahlia opened this issue Dec 4, 2015 · 30 comments
Closed

Transfer the repository to @sass organization? #108

dahlia opened this issue Dec 4, 2015 · 30 comments

Comments

@dahlia
Copy link
Member

dahlia commented Dec 4, 2015

We have now more than one maintainers, so I’m not sure whether this repository still should belong to @dahlia. There's the official organization named @sass, which consists of libsass upstream itself, and several bindings of it e.g. node-sass, perl-libsass, ruby-libsass. I think @sass would be the best place to transfer this repository to, but wonder others' opinions about the idea. Also, I have currently no idea how we can even if we want to do it.

@dahlia
Copy link
Member Author

dahlia commented Dec 4, 2015

Plus: although it might be somewhat off-topic, maintainer of the package metadata (described in setup.py) should contain @asottile.

@mgreter
Copy link
Contributor

mgreter commented Dec 15, 2015

AFAIK @hcatlin would be the right contact. Easiest probably by our slack channel.

@jleclanche
Copy link

Any update on this?

@asottile
Copy link
Member

asottile commented Aug 6, 2016

I'm not entirely convinced. The current repositories contain bindings maintained by the core libsass maintainers. This repository doesn't quite fit that as well

@dahlia
Copy link
Member Author

dahlia commented Aug 6, 2016

Wonder if the binding maintainers became core libsass maintainers, or core libsass maintainers also made bindings as well.

@mgreter
Copy link
Contributor

mgreter commented Jan 12, 2018

@asottile would you like to give this another shot. You definitively would have my support. Unfortunately the perl bindings (which I maintain) are not as popular as your python binding (due to obvious reasons, perl5 just isn't the cool kid on the block anymore 😉). BTW. would really love to ask if you'd be willing to try to integrate native libsass plugins as I did with perl-libsass!? If you're willing to give it a shot either way, count on my support. I really admire what you achieved with the LibSass API so far. Well Done 👍 👏

@asottile
Copy link
Member

I'd be happy to join the org, I'm not sure why I had concerns before but I don't have any now :)

@dahlia owns the repository and would be the contact for transferring it.

Looking forward to the org 🎉

As for native extensions, I'll check out how the perl bindings does them and see if we can fit them in here too!

@mgreter
Copy link
Contributor

mgreter commented Jan 12, 2018

Cool. For the native extensions: They basically just need to be compiled with the same toolchain and the same main libsass dependency into dynamic objects to be loaded via plugin paths. But to conserve disk space it makes sense to have all parts link to the same shared libsass library (was the hardest part in perl-libsass build, but static linking also works).

@mgreter
Copy link
Contributor

mgreter commented Jan 12, 2018

//CC @nex3 @chriseppstein @xzyfer for transfer to the sass org!

@xzyfer
Copy link
Contributor

xzyfer commented Jan 12, 2018 via email

@xzyfer
Copy link
Contributor

xzyfer commented Jan 12, 2018

Had a look. I think the owner/admin of this repo needs to request the transfer, then I can accept it.

@dahlia
Copy link
Member Author

dahlia commented Jan 12, 2018

Sorry for late response. I've just tried to transfer ownership to @sass, but it failed with an error message:

“You don’t have the permission to create repositories on sass”

Is there an other way to “request” the transfer?

@asottile
Copy link
Member

Ah yes, @dahlia needs to be a member of @sass to be able to transfer to it -- I recall this from moving repositories in/out of orgs before.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 13, 2018 via email

@xzyfer
Copy link
Contributor

xzyfer commented Jan 15, 2018 via email

@xzyfer
Copy link
Contributor

xzyfer commented Jan 17, 2018

Looks like the easiest way to do this may be to add me as a collaborator and I should be able to do a transfer requests.

@asottile
Copy link
Member

Collaborator won't have access to that setting -- would need to be added as an owner

@xzyfer
Copy link
Contributor

xzyfer commented Jan 18, 2018

Aha ok I managed to the Sass org permissions sorted out. @dahlia you should have an invite to join the Sass org.

@dahlia
Copy link
Member Author

dahlia commented Jan 18, 2018

I've just received the invitation and joined the org now. I'll transfer the repo right now.

@dahlia
Copy link
Member Author

dahlia commented Jan 18, 2018

Hmm… it still says:

You don’t have the permission to create repositories on sass

even though I now belong to the @sass org.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 18, 2018

Ok try now.

@dahlia
Copy link
Member Author

dahlia commented Jan 18, 2018

Weird. Still the same error occurs:

You don’t have the permission to create repositories on sass

@xzyfer
Copy link
Contributor

xzyfer commented Jan 18, 2018 via email

@chriseppstein
Copy link

chriseppstein commented Jan 18, 2018

Users must have repository creation permissions within the receiving organization before they can transfer a repository that they individually own. If Allow members to create repositories for this organization has been disabled in the receiving organization, only organization owners can transfer repositories into the organization.

We have this setting off. I have enabled it for this transfer and will disable it after it's complete.

@xzyfer
Copy link
Contributor

xzyfer commented Jan 18, 2018

Aha. Thanks @chriseppstein. I've been fumbling around the GH UI for a while now :/

@dahlia
Copy link
Member Author

dahlia commented Jan 19, 2018

Thanks for you all! We've just transferred the repository to @sass org finally!

As we changed the url, there could be several things to do. I'll list them in #229.

@dahlia dahlia closed this as completed Jan 19, 2018
@chriseppstein
Copy link

chriseppstein commented Jan 19, 2018 via email

@xzyfer
Copy link
Contributor

xzyfer commented Jan 19, 2018

Thanks everyone! Welcome to the team @dahlia

@asottile
Copy link
Member

🎉 (do I get an invite too? 😆)

@xzyfer
Copy link
Contributor

xzyfer commented Jan 19, 2018

@asottile aha I thought you were already in the org because of your work LibSass. I've added you to the sass/libsass-python team. Check your inbox :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants