Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about invalid extras during locking #62

Open
uranusjr opened this issue Dec 2, 2018 · 2 comments
Open

Warn about invalid extras during locking #62

uranusjr opened this issue Dec 2, 2018 · 2 comments

Comments

@uranusjr
Copy link
Member

uranusjr commented Dec 2, 2018

Not sure if this is already done. pypa/pipenv#3026.
@techalchemy
Copy link
Member

Likewise, but I don’t think we should fail... presumably we shouldn’t write the bad value?

@uranusjr
Copy link
Member Author

uranusjr commented Dec 2, 2018

I was thinking about dropping invalid extras as well, but that would be more involved to implement. Nice to have, but not necessary and don’t need to be done right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uranusjr @techalchemy