Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Log blocked ressources #12

Open
paavo opened this issue Feb 2, 2022 · 5 comments
Open

feature: Log blocked ressources #12

paavo opened this issue Feb 2, 2022 · 5 comments

Comments

@paavo
Copy link
Contributor

paavo commented Feb 2, 2022

I'd love to see what ressources (script, iframe) were processed with replaceTags in Dev Log.

@paavo
Copy link
Contributor Author

paavo commented Feb 2, 2022

What about a PR integrating LoggerInterface?

@JamesAlias
Copy link
Contributor

Hi @paavo, thanks for caring 🙂

Feel free to submit a PR 👍

A good place to start drafting a Solution would be https://github.com/sandstorm/Sandstorm.CookiePunch/blob/master/Classes/Eel/Helper/CookiePunch.php#L270

@paavo
Copy link
Contributor Author

paavo commented Feb 3, 2022

Thanks for the hint @JamesAlias

I think a setting what to log could make sense 🤔
Personally I'd like to only log (blocked Scripts / iFrames) for services not defined in settings.
Does this make sense to you?

@fheinze
Copy link
Contributor

fheinze commented Feb 4, 2022

Hey @paavo. Thx for your feedback on the package. We are always eager for more context.

  1. Do you want those logs in production because you allow your editors to place HTML NodeTypes and you want to see what they are placing that might need to be unblocked via a consent ...

  2. or is it more about development and integration and you want to see why elements do not show up because they have not been assigned to a service.

Cheers

@paavo
Copy link
Contributor Author

paavo commented Feb 7, 2022

Hi @fheinze
We plan to use the Logs-Feature in development context too see if we missed assigning an integration to a service.
I think about running a crawler to visit all sites and check the log after.

👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants