Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Bug: Marking story as read/unread right after loading will mark different story #1898

Closed
Limero opened this issue Oct 13, 2024 · 3 comments
Assignees

Comments

@Limero
Copy link

Limero commented Oct 13, 2024

This is a bug that happens to me daily and I can easily replicate it. If I open the app, click a feed and too quickly mark a story as read/unread, it will mark a different story. I've not been able to replicate the same bug on Android. Potentially related to #1876

ScreenRecording_10-13-2024.15-12-55_1.mp4
@samuelclay
Copy link
Owner

I've experienced this before as well. Sometimes I'll tap a story and the wrong story will open. @Dejal can you audit this code and come up with ideas for why this might be happening.

@Dejal
Copy link
Collaborator

Dejal commented Nov 8, 2024

I wasn't able to reproduce #1876 (it has the blocked tag). But I'll take another look; even if I can't reproduce either issue, I may be able to add some sanity checks to make sure the right story is accessed.

@macjl
Copy link

macjl commented Nov 8, 2024

I have same issue. It appears frequently, on iPad and iPhone.

Dejal added a commit that referenced this issue Nov 12, 2024
…ferent story)

- Added exta logic to check that a swipe starts and ends on the same row and story, and abandon it if not, to avoid doing the wrong thing.
- It appears that this was caused by reloading a row while loading images, so I also added logic to avoid reloading a row in the middle of a swipe.
@Dejal Dejal closed this as completed Nov 12, 2024
samuelclay added a commit that referenced this issue Nov 13, 2024
* dejal: (21 commits)
  #1898 (Marking story as read/unread right after loading will mark different story)
  Bumped build number
  #1907 (Resizable middle column)
  Fixed #1906 (story list leaves a space after all stories read)
  Backfilling Youtube videos for premium archive subscribers.
  Handling no content when finding feeds.
  Don't guess RSS feed urls on openrss/feedburner domains.
  Adding dashboard_rivers to /reader/feeds?flat=true for #1899
  Deprecating old blog.
  Adding macOS app to Goodies.
  Adding hblog as possible server in nginx.
  Adding docker rule for hblog:80
  New macOS blog post.
  Finishing macOS blog post. Need to upgrade minima theme.
  New screenshots of the macOS app
  #1903 (Saved searches don't work)
  #1902 (Adjust position of unread indicator on story title select)
  #1247 (Mac Catalyst edition)
  Prep
  #1247 (Mac Catalyst edition)
  ...
samuelclay added a commit that referenced this issue Nov 18, 2024
* master: (36 commits)
  Static deploys should force gunicorn reload.
  New X/Twitter icons.
  New Android screenshots.
  New screenshots for homepage, updating all twitter links to x.com. Still need Android screenshot from S22.
  Android 13.3.2 230
  #1886 Support for themed icons
  #1898 (Marking story as read/unread right after loading will mark different story)
  Bumped build number
  #1907 (Resizable middle column)
  Fixed #1906 (story list leaves a space after all stories read)
  #1903 (Saved searches don't work)
  #1902 (Adjust position of unread indicator on story title select)
  #1247 (Mac Catalyst edition)
  Prep
  Add nullability annotations to ReadingAction
  #1247 (Mac Catalyst edition)
  Fixed offline images not appearing
  Android 13.3.1 229
  #1891 Handle Android 9 and below for OPML file export
  Add nullability annotation to help with Kotlin conversion
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants