-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Mac Catalyst edition #1247
Comments
Oh I remember attempting to transition to WKWebView a long time ago and it was not fun. I ultimately abandoned that branch. That said, I would love to see this. NewsBlur was originally developed to replace NNW, a Mac app. |
NetNewsWire has a new lease on life now. But I'm sure Brent would welcome other Mac newsreaders. Yeah, transitioning to Okay, I will begin work on that in the next month or two, depending on other priorities that come up in the meantime. |
- It’s alive, ALIVE! - You can now build and run NewsBlur for macOS! - Still lots of issues, including the story CSS not rendering properly, but it works. - Plus of course making things more Mac-like, like modal views as real windows, etc. - Committed to a new branch, since not ready for prime time.
A partial list of issues I've noticed, that I'll work on in the coming months, as time allows:
|
On the three-pane, I would love to rethink how NewsBlur iOS app has the panes. Today it's not great, but it works. I would be happy to move to something a bit more like sliding doors (ala Reeder), although that would make the dashboard river harder to show. |
Work on the three pane option (and much more) is underway; see #817 for more info. |
Looking good! Stories aren't tappable right now, but using the keyboard shortcut got around that. Also, the login screen needs adjustment (ugh, such an old view too). |
I take that back, I prefer the extra story titles. But that's for the widget (#1334). Let's widen the story titles a bit. Looks like they widen on their own at ~2000px. Also, let's add a max-width to images of 1200px or something. |
The Catalyst branch and Mac app are not ready for release yet. This is on hold until more required changes are done. |
Should I still be merging in catalyst into testflight? |
No, merge Dejal to TestFlight. |
It's really great! What happened to the widget? I want to see it in my widget dashboard on macos. |
As I recall, the widget isn't included in the Alpha build, for some technical reason I forget right now (maybe related to the bundle identifier or something). I'll take another look at that when next working on it. |
- Added widget on Mac. - Updated to support latest layout APIs.
- Added the user info, with several tweaks to fit. - Getting the avatar to show up was tricky. - Nav bar buttons on the right.
- Migrated to modern window scene support. - Customized the menu bar, with Theme submenu, and new Site and Story menus (some items not implemented yet).
- Updated the About window. - Now has Mac-specific settings. - Split Settings window into multiple panes.
- More Settings tweaks. - Fixed squished theme control swatches. - Resized toolbar buttons to Mac-appropriate sizes. - Fixed position of story detail settings popover.
- Added Mute, Organize, Widget Sites etc commands to the File menu. - Added Columns, Text Size, and Spacing commands to the View menu. - Investigated nav bar theming; appears to be outside scope of window. - Investigated menu disabling; WIP.
* master: (69 commits) iOS v13.1.1, fixing crash on iOS 16. Bumped version number Fixed crash on older iOS versions iOS v13.1 Handling missing youtube duration. Fixing strip underscore iOS 15 screenshots Don't use the underscore cache buster anymore. Correct archive sub count Don't resync stories on new sub if it already has archive subscribers. More numpy changes. Strip underscores from feed addresses, special case jwz Load offline story images even when online to speed up image display. #1875 (borders between panes not using theme colors) #1247 (Mac Catalyst edition) #1874 (Crash on opening widget story) Allowing traffic on docker0 interface. Clean TXT records so letsencrypt doesn't fail Thresholding bounced newsletters email. #1247 (Mac Catalyst edition) ...
I had the Mac app running in the background all day today, every hour or so bringing it to the foreground and changing feeds/stories, but every time it has shown the story on activating the app; no blank stories. I was able to reproduce the issue before my June 27 fix, but not since. So I'll need you to re-check it, and hopefully provide more clues if it is still occurring. |
Yeah I've noticed it went away so I'll chalk it up to running an older build. At this point I'll need to assembly screenshots and launch it on the mac app store, which I'll try to do in the next few days. I just moved to SF so I'm without furniture for the next couple weeks, so I'll be limited in what I can achieve. |
Yeah, likely using an older build. I'm glad it's resolved. I'll have a new TestFlight in the next few days, so it'd make sense to wait for that. Best of luck getting set up in SF! |
I manually changed it but we should include a way to use the system theme. This probably goes for the iOS app as well, as a fifth theme color for "Auto" |
Can we add "Auto" to the segmented control? I find myself wanting to override it but not wanting to go back into preferences. I'll make this a separate ticket. |
Ok, the app was rejected for the following reasons:
So basically we need to support in app purchases and make it so the app can be re-opened on close. I agree with the re-open on close feature, I was missing that. As for the in app purchases, they won't let us punt on that. |
The main window can not be closed. The Close menu item and window button are disabled. So you might need to ask for clarification if they didn't notice that, or were able to somehow close the window. |
Can you make it so that the app can be closed and then re-opened? Upon re-opening, it refreshes the feed list and loads the all site stories. |
I've just experimented with allowing closing the window and re-opening it. I don't think that is feasible for NewsBlur at this stage, as it doesn't really support multiple "scenes", i.e. opening another window. Adding that support would require major refactoring. I'll next experiment with quitting the app when the window is closed. Catalyst doesn't make that easy, but it might be possible. I previously thought that preventing closing would be better, to avoid accidentally closing (you can always quit and re-launch). |
- Enabled the Close menu item and window button for the NewsBlur window. - Closing the window quits the app.
App was rejected on these grounds:
So let's add account deletion to the Preferences dialog underneath Advanced. Make sure to add a confirmation message. |
Is there an API for that, or a standalone web page that I can send the user to, to delete the account? |
There's both, but let's use this webpage: https://www.newsblur.com/profile/delete_account |
It isn't possible to add a button to the Settings window on macOS; it is managed by the Catalyst system using the Settings bundle. More concerning, Sequoia seems to have broken the Settings window; it doesn't appear anymore. I'm investigating. So I'll have to add the delete account option elsewhere. Could be in the File menu below "Logout NewsBlur". Or could add it to the confirmation alert for logout — have "Cancel", "Logout", and "Delete Account" buttons. The latter would log out then show the delete account page. (Would be good to log out when deleting the account anyway.) What would you prefer? |
- Settings fix for Sequoia. - Added Delete Account to Logout confirmation; if chosen, logs out and shows the Delete Account web page. - Fixed crash in reloading feed after logging out.
I decided that the latter suggestion was best, so implemented that. And fixed the Settings issue with Sequoia. TestFlight build incoming.... |
* master: Postgres secondary Prometheus 500GB data. New forum server. Adding youtube feeds to PuSH. Adding macOS screenshots. Updating ansible setup. #1890 (Add Auto to theme selector) #1247 (Mac Catalyst edition) Fixed a feed detail swipe starting on one row and ending on another causing the wrong row being marked unread Prep
I've been using the macOS app a ton and it's been a great experience. One change I'd like to see is to match the up-to-date experience from the web. We have a configurable dashboard on the web that has real-time updated "widgets". Could we make a new "Dashboard" top level folder, same as on the web, with the story titles in groups matching the web? I publish those lists on
They should show 5 stories in the standard story titles format, and they should reload every 5 minutes (add a random 1-5 minutes per request so they don't all refresh together at once, some people can have dozens of rivers). I'd like to see this on both iPad and macOS, so I can leave the screen open and watch the news come in. Bonus points for left vs right lists. And extra bonus points for single column, double column, and two horizontal columns (left "column" on top row, right "column" on bottom row). |
That's an intriguing idea. Though this really should be a new issue, since it's only tangentially related to the Mac app; as you say, it'd be beneficial on the iPad app too. I've added #1899. |
- Added Manage Account on the Web to Help menu.
It's approved! I'll blog about this tomorrow or early next week. Congrats, it's a terrific release and I'm very hungry for #1899 because not only will that get its own blog post but it'll help the mac app become a more present part of people's day. |
Yay! I'm sure lots of people will be thrilled by a native Mac edition of NewsBlur. Very exciting to get it out there. I will be available next week for any urgent fixes (please add as new issues), or otherwise working on #1899. |
* dejal: (21 commits) #1898 (Marking story as read/unread right after loading will mark different story) Bumped build number #1907 (Resizable middle column) Fixed #1906 (story list leaves a space after all stories read) Backfilling Youtube videos for premium archive subscribers. Handling no content when finding feeds. Don't guess RSS feed urls on openrss/feedburner domains. Adding dashboard_rivers to /reader/feeds?flat=true for #1899 Deprecating old blog. Adding macOS app to Goodies. Adding hblog as possible server in nginx. Adding docker rule for hblog:80 New macOS blog post. Finishing macOS blog post. Need to upgrade minima theme. New screenshots of the macOS app #1903 (Saved searches don't work) #1902 (Adjust position of unread indicator on story title select) #1247 (Mac Catalyst edition) Prep #1247 (Mac Catalyst edition) ...
* master: (36 commits) Static deploys should force gunicorn reload. New X/Twitter icons. New Android screenshots. New screenshots for homepage, updating all twitter links to x.com. Still need Android screenshot from S22. Android 13.3.2 230 #1886 Support for themed icons #1898 (Marking story as read/unread right after loading will mark different story) Bumped build number #1907 (Resizable middle column) Fixed #1906 (story list leaves a space after all stories read) #1903 (Saved searches don't work) #1902 (Adjust position of unread indicator on story title select) #1247 (Mac Catalyst edition) Prep Add nullability annotations to ReadingAction #1247 (Mac Catalyst edition) Fixed offline images not appearing Android 13.3.1 229 #1891 Handle Android 9 and below for OPML file export Add nullability annotation to help with Kotlin conversion ...
Now that iOS 13 and macOS Catalina introduces the ability to build iOS apps for macOS, via Catalyst, there may be customer demand for a Mac edition of NewsBlur.
I've turned on the checkbox to build under Catalyst in a local branch, as an experiment, but there are a number of issues preventing successful building of a Mac app:
The most significant is the reliance on
UIWebView
. That is not supported in Catalyst, requiring usingWKWebView
instead. That isn't a simple transition, though: the web view is used extensively in NewsBlur, with JavaScript interactions and such, which would require many changes. It should be feasible, though. And may have to be done in due course even for the iOS app, sinceUIWebView
has been discouraged since iOS 8, and is now formally deprecated as of iOS 13, in addition to being unavailable for Catalyst.There's an error related to using the
AddressBook
framework, but that doesn't seem to be used, so can be removed.There are many deprecation warnings, but those shouldn't be too hard to fix (and again will need to be addressed in due course).
Beyond those, of course, the app would need many changes to work well as a Mac app, including adding a menubar, probably some layout changes, and other UI tweaks.
But I think it could a a popular option for many people. Something to consider. Let me know if you want me to explore further.
The text was updated successfully, but these errors were encountered: