Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new events #52

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add new events #52

wants to merge 8 commits into from

Conversation

samliew
Copy link
Owner

@samliew samliew commented Nov 2, 2024

Type of change

  • Bugfix
  • New Feature
  • Existing Feature
  • Content Change

Pre-review checklist

  • I have commented my code (where applicable)
  • I have checked the spelling/grammar (where applicable)
  • I have checked the dates and link references (where applicable)

Brief description of the change:

Add new events JSON from Issues

Is this feature/update deployment associated with any issues?

closes #42
closes #41
closes #44
closes #47
closes #48
closes #49
closes #50
closes #51

@samliew samliew requested a review from Oaphi November 2, 2024 08:58
@samliew samliew self-assigned this Nov 2, 2024
@9ao9ai9ar
Copy link
Collaborator

I quickly glanced through the changes and everything seemed to be in order, but since I'm the one who generated these JSON objects through the Event Editor, it's better if it's someone else who reviewed and approved the pull request. Also, in #42 @Oaphi requested that more description be added before proceeding, to which I replied that I'm not well equipped to do so. Therefore that part may need a bit more input from other reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants