Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left/right arrows even when using a touchscreen #505

Open
foxharp opened this issue Nov 18, 2023 · 6 comments
Open

left/right arrows even when using a touchscreen #505

foxharp opened this issue Nov 18, 2023 · 6 comments

Comments

@foxharp
Copy link

foxharp commented Nov 18, 2023

The photoswipe code goes out of its way to disable the left and right arrow icons when it's known that the display device has a touchscreen (where the assumption is that swiping left/right will be used instead). That's okay, unless your laptop has a touchscreen. Then, when you bring up the gallery, and you're busy using your keyboard and mouse for everything, and had sort of forgotten for a while that you have a touchscreen, you find yourself without a way to navigate to the next/previous images.

It would be better to have the arrows always present, or, at least, for there to be an obvious way to enable them. I'm normally pretty good at ferreting out how to tweak javascript to do what I want, and am running a customized copy of photoswipe, but I can't for the life of me figure out how to get the arrows to appear unconditionally. (A pointer would be most welcome!)

@saimn
Copy link
Owner

saimn commented Nov 22, 2023

That's a feature request for Photoswipe ;).
But the version in sigal is pretty old (v4.4.0), maybe worth checking their release notes first (https://github.com/dimsemenov/PhotoSwipe/releases). And I should update it at some point ...

@saimn
Copy link
Owner

saimn commented Nov 18, 2024

I updated photoswipe to the latest version (#528), please test if it is better now.

@foxharp
Copy link
Author

foxharp commented Nov 18, 2024

No change, I'm afraid. I get arrows (which disappear on a short timeout, and reappear with mouse movement) on a non-touchscreen display, but no arrows at all on my laptop. Keyboard arrow keys work on both. Both are running the latest Google Chrome.

I've kind of gotten used to it. :-)

@saimn
Copy link
Owner

saimn commented Nov 20, 2024

Then I guess it's something to report on photoswipe side if you want to ;)

@foxharp
Copy link
Author

foxharp commented Nov 20, 2024

Maybe I didn't test what I thought I was supposed to. I did a "/usr/bin/pip install --upgrade sigal", and I seem to have 2.4, but I now realize that that was released in 2023. Perhaps you were thinking I'd test from your git tree?

@saimn
Copy link
Owner

saimn commented Nov 20, 2024

Yes currently you would need to test from the git version. I will try to do a release "soon".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants