-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Album with hundreds of thumbnails crash Safari on iOS devices #497
Comments
I have produced a simple example gallery here that causes the page Safari on iPhone to crash. URL is: http://129.151.214.239/tmp/1/sigal/ Steps to reproduce: I have attached a tar.gz with the example gallery in it. This is just a static html gallery that can be opened locally on a webserver. (e.g. start a python webserver, etc. in the folder) |
No sigal is using Galleria's API for lazy loading (https://galleriajs.github.io/docs/api/methods.html#lazyloadchunks-size-delay). Maybe there is a bug somewhere, maybe it was fixed on Galleria's side, maybe not. |
Yeah, I think the problem is that Galleria implements their own Lazy loading instead of using the built in HTML5 |
What do you mean by lazy loading? Looking at the developer console, all images are fetched eagerly (firefox/linux) |
this galleria theme (folio) displays all thumbnails in the page so maybe try another galleria theme ? |
all images are fetched, at least on the page mentioned in in #497 (comment) |
Am I understanding this correctly, that this bug (Safari crashing) is caused by the Galleria theme. And the Galleria theme is not updated since 2019 - perhaps the project is abandoned? Should I open a ticket on the Galleria project instead? |
Galleria is unmaintained (last commit from 2020) and I'm not aware of a fork that would be community maintained. |
Hi,
A gallery with hundreds of images seem to crash Safari on iOS. Since all browsers on iOS internally use Safari for rendering, this means that effectively, iOS users (iPhones, iPads, etc) are not able to access Sigal albums with hundreds of images in them.
I have not been able to find the exact number of thumbnails that causes this to occur. Indeed, it does not seem to be a specific number. It seems the actual images matter. So maybe it is relating to some memory/buffer size.
It seems to me that the reason this happens is that Sigal's gallaria uses its own custom JS code to implement lazy loading of thumbnails. My hypothesis is that this lazy loading code builds up some huge javascript object that causes Safari to run into some memory limit and the page crashes.
I think the custom JS implementation of lazy loading could be omitted entirely and replaced by built in HTML features for lazy loading, namely:
<img src="image.jpg" alt="foo" loading="lazy" />
Would it be feasible to change this in Sigal's gallaria?
The text was updated successfully, but these errors were encountered: