-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glob follows symlinks recursively #281
Comments
thanks for reporting. which glob crate do you recommend? |
We no longer have the symlink, so this isn't a pressing need any more. But it would still be nice lower-priority cleanup. I've used globset before, maintained by @BurntSushi. It is more featureful than |
The glob situation in Rust is not so great. I built Anything that's built on |
Describe The Bug
In a directory that has a recursive symbolic link, the duckscript
glob_array
command performs a cyclic recursion.To Reproduce
glob_array
Commentary
This is a bug in
glob
, notduckscript
, butduckscript
isn't completely off the hook because theglob
crate has had an issue open since 2017 (rust-lang/glob#62), and a PR to fix it, but the crate hasn't been updated in several years. There are other glob-like crates in the ecosystem now with better options, including ones to ignore symlinks. It might be worthwhile migrating to one of them.The text was updated successfully, but these errors were encountered: