Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages-Transaction History changing based on Ownership #4575

Open
ru513 opened this issue Nov 28, 2024 · 1 comment
Open

Messages-Transaction History changing based on Ownership #4575

ru513 opened this issue Nov 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ru513
Copy link

ru513 commented Nov 28, 2024

Bug description

The n-out-of-n message is taking the current signer make up, not the historical settings at the time of the transaction.

The messages in the screenshot were all fully signed, after changing removing signers they are shown as incomplete / waiting for another signer.

In the screenshot you can see the 3/3 signatures at the time of the change in ownership, with 2/3 before, in actual fact all are 3/3.

Environment

Steps to reproduce

Go to https://app.safe.global/transactions/messages?safe=eth:0x0bC46509AC0689bBEBA653ebF207A2a0CB3F5EFb

Expected result

After changing signers , messages should be remain as complete and historical transactions shouldn't change.

Obtained result

Messages in transaction history shown as waiting for an additional signature

Screenshots

Screenshot 2024-11-28 at 09 19 01
@ru513 ru513 added the bug Something isn't working label Nov 28, 2024
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Nov 28, 2024
@katspaugh katspaugh moved this from New issues to Todo in Web Squad Nov 28, 2024
@liliya-soroka
Copy link
Member

not a bug. This is how the feature work. If the owner is removed ( example: if the owner was compromised and was replaced by another one), his signature is removed for the messages and txs in queued list .
I will convert the ticket to the feature request to discuss with product team

@liliya-soroka liliya-soroka added enhancement New feature or request and removed bug Something isn't working labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants