Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SW-543 : Blockaid: "The transaction could not be checked.." on UI when the response has error from blockaid #4531

Open
liliya-soroka opened this issue Nov 18, 2024 · 0 comments
Labels
bug Something isn't working major Major bug (to be solved in the next release)

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 18, 2024

Bug description

Blockaid: "The transaction could not be checked.." on UI when the response has error from blockaid

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Go to eth:0x8675B754342754A30A2AeF474D114d8460bca19b
  2. try to create send tx for the spam token" $ ETH35.com"
  3. check risk error
    Current result: the tx could not be checked and no balance change on UI
image
  1. check the scan request to blockaid and response
    Current result:
image Payload : `{"chain":"ethereum","account_address":"0x8675B754342754A30A2AeF474D114d8460bca19b","data":{"method":"eth_signTypedData_v4","params":["0x8675B754342754A30A2AeF474D114d8460bca19b","{\"types\":{\"EIP712Domain\":[{\"type\":\"uint256\",\"name\":\"chainId\"},{\"type\":\"address\",\"name\":\"verifyingContract\"}],\"SafeTx\":[{\"type\":\"address\",\"name\":\"to\"},{\"type\":\"uint256\",\"name\":\"value\"},{\"type\":\"bytes\",\"name\":\"data\"},{\"type\":\"uint8\",\"name\":\"operation\"},{\"type\":\"uint256\",\"name\":\"safeTxGas\"},{\"type\":\"uint256\",\"name\":\"baseGas\"},{\"type\":\"uint256\",\"name\":\"gasPrice\"},{\"type\":\"address\",\"name\":\"gasToken\"},{\"type\":\"address\",\"name\":\"refundReceiver\"},{\"type\":\"uint256\",\"name\":\"nonce\"}]},\"domain\":{\"verifyingContract\":\"0x8675B754342754A30A2AeF474D114d8460bca19b\",\"chainId\":\"1\"},\"primaryType\":\"SafeTx\",\"message\":{\"to\":\"0xC6d3D201530a6D4aD9dFbAAd39C5f68A9A470a69\",\"value\":\"0\",\"data\":\"0xa9059cbb00000000000000000000000065f8236309e5a99ff0d129d04e486ebce20dc7b0000000000000000000000000000000000000000000000000000000000000000a\",\"operation\":0,\"baseGas\":\"0\",\"gasPrice\":\"0\",\"gasToken\":\"0x0000000000000000000000000000000000000000\",\"refundReceiver\":\"0x0000000000000000000000000000000000000000\",\"nonce\":397,\"safeTxGas\":\"0\"}}"]},"options":["simulation","validation"],"metadata":{"domain":"feat_nested_owner_signing--walletweb.review.5afe.dev"}}`

Expected result

Show the error from the blockaid on UI instead of "The tx could not be checked..."

Obtained result

Screenshots

Notion

https://www.notion.so/safe-global/Blockaid-The-transaction-could-not-be-checked-on-UI-when-the-response-has-error-from-blockaid-1428180fe5738056ba10d02cf0f22874?pvs=4

@liliya-soroka liliya-soroka added the bug Something isn't working label Nov 18, 2024
@liliya-soroka liliya-soroka changed the title Blockaid: "The transaction could not be checked.." on UI when the response has error from blockaid [SW-543] Blockaid: "The transaction could not be checked.." on UI when the response has error from blockaid Nov 18, 2024
@liliya-soroka liliya-soroka changed the title [SW-543] Blockaid: "The transaction could not be checked.." on UI when the response has error from blockaid SW-543 : Blockaid: "The transaction could not be checked.." on UI when the response has error from blockaid Nov 18, 2024
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Nov 18, 2024
@liliya-soroka liliya-soroka added the major Major bug (to be solved in the next release) label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major Major bug (to be solved in the next release)
Projects
Status: New issues
Development

No branches or pull requests

1 participant