Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested safes: support Off-chain messages signing #4496

Open
liliya-soroka opened this issue Nov 6, 2024 · 0 comments
Open

Nested safes: support Off-chain messages signing #4496

liliya-soroka opened this issue Nov 6, 2024 · 0 comments
Labels
enhancement New feature or request major Major bug (to be solved in the next release)

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 6, 2024

Bug description

Nested safes: Off-chain messages signing doesn't work
image

Environment

  • Browser: Chrome and FF
  • Wallet: parent safe
  • Chain: any

Steps to reproduce

  1. create a message in the child safe and sign with parent safe ( 2 of N) fully
  2. return to the child safe

Current result: CGW -400: 2 signatures are received when 1 was expected

Expected result

It should be possible to do off-chain signing with the parent safe if parent safe is 2/N and more

Obtained result

notion issue - https://www.notion.so/safe-global/Nested-safes-Off-chain-messages-signing-doesn-t-work-1368180fe5738031bd74f8653185328c?pvs=4

@liliya-soroka liliya-soroka added bug Something isn't working major Major bug (to be solved in the next release) labels Nov 6, 2024
@liliya-soroka liliya-soroka added enhancement New feature or request and removed bug Something isn't working major Major bug (to be solved in the next release) labels Nov 15, 2024
@liliya-soroka liliya-soroka changed the title Nested safes: Off-chain messages signing doesn't work Nested safes: support Off-chain messages signing Nov 15, 2024
@liliya-soroka liliya-soroka added the major Major bug (to be solved in the next release) label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major Major bug (to be solved in the next release)
Projects
None yet
Development

No branches or pull requests

1 participant