Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable add to batch for safeApps #4392

Open
compojoom opened this issue Oct 18, 2024 · 1 comment
Open

Disable add to batch for safeApps #4392

compojoom opened this issue Oct 18, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@compojoom
Copy link
Contributor

When doing a transaction from a safe App the user is able to sign/execute the tx or "add to batch". When the user signs the tx, we return the txId to the dapp. The Dapp is able to follow on their end what happens with the transaction. That's not the case when a user ads a tx to a batch. If that happens we just close the "transaction sign/execute" flow without retuning any hash to the dapp. The Problem is that we cannot return the hash of the transaction that was added to batch. The safeTX hash we have won't be for the tx that is later going to be executed on chain. The batch execution tx would have a different txId.
Because of this I think that it would be good to disable the "add to batch" button for 3rd party dapps.

@compojoom compojoom added bug Something isn't working enhancement New feature or request labels Oct 18, 2024
@liliya-soroka
Copy link
Member

Steps:

  1. Open cowswap or tx builder app
  2. create a tx with one action ( wrap in cowswap or send eth/erc20 to another account)
  3. start the tx creation
    Current result "Add to batch" is available
    If the tx from the safe app contains a few actions the "add to batch" is disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@liliya-soroka @compojoom and others