Use Gateway instead of Transaction Service to fetch module ID #3815
Labels
Comments
|
This is fixed in 4e61b38 |
jfschwarz
added a commit
that referenced
this issue
Jul 18, 2024
katspaugh
pushed a commit
that referenced
this issue
Jul 19, 2024
* use latest subgraphs * fix multisend handling * query multisend addresses configured on roles mod * use queried known multisend address * handle multisend impossible edge case * fold execute through role section into the main sign or execute card * fix exec through role status checks * design updates * add powered by zodiac badge * test hooks * improve tests * test coverage for new logic in SignOrExecute main component * fix a bug and margins between error messages * fix a bug: offer exec through role also if threshold is 1 but not connected with owner * adjust test and improve error messages * don't offer exec through role for safe owners if role lacks permissions * fix failing test * use client gateway to fetch tx id closes #3815 * mock useGasPrice --------- Co-authored-by: Jan-Felix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the feature about
In order to get the module ID of a module-executed transaction, it is necessary to query using the transaction hash. However, the Gateway did not support this and the Transaction Service was therefore being used directly. We have since implemented a
transaction_hashquery on themodule-transactionsendpoint of the Gateway to support this.Fetching of the module ID from the Transaction Service should now be ported to the Gateway. The ID can be retrieved from the
txId.Note: we will eventually return the module ID in the response meaning that it need not be destructure from the
txId.The list of requirements
txId(The SDK will need first be updated for type safety)
The text was updated successfully, but these errors were encountered: